Skip to content

[codex] Clean up core OAuth discovery errors#543

Merged
RhysSullivan merged 1 commit intocodex/effect-lint-baselinefrom
codex/effect-lint-core-sdk-oauth
May 6, 2026
Merged

[codex] Clean up core OAuth discovery errors#543
RhysSullivan merged 1 commit intocodex/effect-lint-baselinefrom
codex/effect-lint-core-sdk-oauth

Conversation

@RhysSullivan
Copy link
Copy Markdown
Owner

Summary

  • remove unknown error message/stringification from OAuth helper and discovery failures
  • inline OAuth discovery tagged errors instead of using a trivial factory
  • keep native/provider details in typed cause fields while using stable public messages
  • update OAuth helper/discovery tests to avoid native Error and tagged-error instanceof checks

Validation

  • bun run typecheck in packages/core/sdk
  • bunx vitest run src/oauth-helpers.test.ts src/oauth-discovery.test.ts in packages/core/sdk
  • bunx oxlint -c .oxlintrc.jsonc packages/core/sdk/src/oauth-helpers.ts packages/core/sdk/src/oauth-discovery.ts packages/core/sdk/src/oauth-discovery.test.ts packages/core/sdk/src/oauth-helpers.test.ts --deny-warnings

Stacked on #535.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 6, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing 0bbd756 Commit Preview URL

Branch Preview URL
May 06 2026, 12:26 AM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 6, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
❌ Deployment failed
View logs
executor-cloud 0bbd756 May 06 2026, 12:27 AM

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 6, 2026

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@543

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@543

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@543

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@543

@executor-js/storage-core

npm i https://pkg.pr.new/@executor-js/storage-core@543

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@543

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@543

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@543

@executor-js/plugin-google-discovery

npm i https://pkg.pr.new/@executor-js/plugin-google-discovery@543

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@543

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@543

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@543

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@543

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@543

executor

npm i https://pkg.pr.new/executor@543

commit: 0bbd756

@RhysSullivan RhysSullivan force-pushed the codex/effect-lint-core-sdk-oauth branch from ec241d1 to 0bbd756 Compare May 6, 2026 00:25
@RhysSullivan RhysSullivan merged commit fbcc52b into codex/effect-lint-baseline May 6, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant