Merged
Conversation
Removes the top level async function that had previously been wrapped around the transformed code. This ensures consistent behavior between node and lit-node, which became an issue after pull request #5 made it possible to load lit-node as a module instead of using it as a drop-in replacement for the node interpreter. This means top-level use of the await keyword is no longer allowed. Fixes #6.
The test checking whether error locations are properly located in stack traces is part of a larger set of tests which are all contained in test.md, and it tests against its own location within that file, which means it is possible for the test to fail when other tests are edited if those edits result in changes to the line number of the stack trace test within the test.md file. This would be best handled be moving it into a discrete file which is unlikely to be edited at all, but so long as the tests are lumped together in a single monolithic test suite, it is at least useful to move the position of the stack trace up so edits to the other tests are less likely to affect its line number within the file.
ensure tests pass before publishing to npm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the top-level async function wrapper, which causes a number of problems; consequently, top-level use of the
awaitkeyword is no longer allowed.