Feature/limit & filter &wildcard operator impl#19
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements limit and filter operators for the query execution engine, along with comparison and logical operators (Equal, NotEqual, LessThan, GreaterThan, And, Or) in the expression evaluation system. The PR also refactors the ExprDataType function to return errors instead of panicking, removes predicate pushdown functionality from the parquet source, and fixes a spelling error.
Key Changes:
- Implements
LimitExecandFilterExecoperators with comprehensive test coverage - Adds comparison and logical operator support to the expression evaluation system
- Changes
ExprDataTypeto return(arrow.DataType, error)instead of panicking - Removes predicate pushdown from
ParquetSource
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
operators/record.go |
Adds ColumnByName helper method for retrieving columns by name |
operators/filter/limit.go |
Implements the LimitExec operator to limit query results |
operators/filter/limit_test.go |
Comprehensive test coverage for LimitExec including edge cases |
operators/filter/filter.go |
Implements the FilterExec operator with predicate validation |
operators/filter/filter_test.go |
Extensive test coverage for FilterExec with various predicates |
Expr/expr.go |
Implements comparison/logical operators and refactors error handling |
Expr/expr_test.go |
Updates tests for new error-returning ExprDataType and adds filter operator tests |
operators/project/projectExec.go |
Updates to handle error-returning ExprDataType |
operators/project/projectExec_test.go |
Removes obsolete test for unimplemented operators |
operators/project/projectExecExpr_test.go |
Fixes spelling error in test message |
operators/project/parquet.go |
Removes predicate pushdown, adds timestamp array combining, changes batch size |
operators/project/parquet_test.go |
Updates tests to remove predicate pushdown parameter |
CONTRIBUTING.md |
Adds -count=1 flag to test command to disable caching |
Comments suppressed due to low confidence (1)
src/Backend/opti-sql-go/operators/project/parquet.go:1
- The error message is incomplete and ends with "got %v and " without showing the second value. This makes the error message unclear. Since predicatePushDown was removed, the message should be updated to only mention projectionPushDown.
package project
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated 17 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f807c01 to
1907dd3
Compare
…or-Impl Feature/limit & filter &wildcard operator impl
…or-Impl Feature/limit & filter &wildcard operator impl
No description provided.