Skip to content

Feature/limit & filter &wildcard operator impl#19

Merged
Rich-T-kid merged 3 commits intopre-releasefrom
feature/Limit-Filter-WC-Operator-Impl
Nov 21, 2025
Merged

Feature/limit & filter &wildcard operator impl#19
Rich-T-kid merged 3 commits intopre-releasefrom
feature/Limit-Filter-WC-Operator-Impl

Conversation

@Rich-T-kid
Copy link
Copy Markdown
Owner

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements limit and filter operators for the query execution engine, along with comparison and logical operators (Equal, NotEqual, LessThan, GreaterThan, And, Or) in the expression evaluation system. The PR also refactors the ExprDataType function to return errors instead of panicking, removes predicate pushdown functionality from the parquet source, and fixes a spelling error.

Key Changes:

  • Implements LimitExec and FilterExec operators with comprehensive test coverage
  • Adds comparison and logical operator support to the expression evaluation system
  • Changes ExprDataType to return (arrow.DataType, error) instead of panicking
  • Removes predicate pushdown from ParquetSource

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
operators/record.go Adds ColumnByName helper method for retrieving columns by name
operators/filter/limit.go Implements the LimitExec operator to limit query results
operators/filter/limit_test.go Comprehensive test coverage for LimitExec including edge cases
operators/filter/filter.go Implements the FilterExec operator with predicate validation
operators/filter/filter_test.go Extensive test coverage for FilterExec with various predicates
Expr/expr.go Implements comparison/logical operators and refactors error handling
Expr/expr_test.go Updates tests for new error-returning ExprDataType and adds filter operator tests
operators/project/projectExec.go Updates to handle error-returning ExprDataType
operators/project/projectExec_test.go Removes obsolete test for unimplemented operators
operators/project/projectExecExpr_test.go Fixes spelling error in test message
operators/project/parquet.go Removes predicate pushdown, adds timestamp array combining, changes batch size
operators/project/parquet_test.go Updates tests to remove predicate pushdown parameter
CONTRIBUTING.md Adds -count=1 flag to test command to disable caching
Comments suppressed due to low confidence (1)

src/Backend/opti-sql-go/operators/project/parquet.go:1

  • The error message is incomplete and ends with "got %v and " without showing the second value. This makes the error message unclear. Since predicatePushDown was removed, the message should be updated to only mention projectionPushDown.
package project

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Backend/opti-sql-go/operators/filter/limit_test.go Outdated
Comment thread src/Backend/opti-sql-go/operators/filter/limit.go Outdated
Comment thread src/Backend/opti-sql-go/operators/filter/filter.go Outdated
Comment thread src/Backend/opti-sql-go/operators/filter/filter.go Outdated
Comment thread src/Backend/opti-sql-go/operators/filter/limit.go Outdated
Comment thread src/Backend/opti-sql-go/operators/filter/filter.go Outdated
Comment thread src/Backend/opti-sql-go/operators/filter/filter_test.go Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 17 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Backend/opti-sql-go/Expr/expr_test.go Outdated
Comment thread src/Backend/opti-sql-go/Expr/expr_test.go Outdated
Comment thread src/Backend/opti-sql-go/Expr/expr_test.go Outdated
Comment thread src/Backend/opti-sql-go/Expr/expr_test.go Outdated
Comment thread src/Backend/opti-sql-go/Expr/expr_test.go Outdated
Comment thread src/Backend/opti-sql-go/Expr/expr.go
Comment thread src/Backend/opti-sql-go/operators/filter/filter.go Outdated
Comment thread src/Backend/opti-sql-go/Expr/expr_test.go Outdated
Comment thread src/Backend/opti-sql-go/Expr/expr_test.go Outdated
Comment thread src/Backend/opti-sql-go/Expr/expr.go
@Rich-T-kid Rich-T-kid force-pushed the feature/Limit-Filter-WC-Operator-Impl branch from f807c01 to 1907dd3 Compare November 21, 2025 17:37
@Rich-T-kid Rich-T-kid merged commit 28eea13 into pre-release Nov 21, 2025
Rich-T-kid added a commit that referenced this pull request Nov 21, 2025
…or-Impl

Feature/limit & filter &wildcard operator impl
Rich-T-kid added a commit that referenced this pull request Nov 21, 2025
…or-Impl

Feature/limit & filter &wildcard operator impl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants