Skip to content

feat: generate test substrait plans & basic parse#36

Merged
MarcoFerreiraPerson merged 2 commits intopre-releasefrom
feature/Parse-SS
Dec 22, 2025
Merged

feat: generate test substrait plans & basic parse#36
MarcoFerreiraPerson merged 2 commits intopre-releasefrom
feature/Parse-SS

Conversation

@Rich-T-kid
Copy link
Copy Markdown
Owner

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds high-level architectural comments to the substrait package, outlining the planned workflow for processing Substrait plans: converting raw bytes to plans, parsing to an AST, optimizing, and executing operators. The comments serve as a roadmap for future implementation.

  • Added architectural comments documenting the planned workflow for Substrait plan processing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +3 to +7
// turn raw bytes to substrait plan
// parse substrait plan to in memory format we can work with (abstract syntax tree)
// optimize the plan (apply optimizations)
// run operators based on the optimized plan
//
Copy link

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments should follow Go documentation conventions: start with a capital letter and end with a period. Additionally, "in memory" should be hyphenated as "in-memory" when used as a compound adjective. The trailing empty comment line (line 7) should be removed as it serves no purpose.

Suggested format:

// Turn raw bytes to substrait plan.
// Parse substrait plan to in-memory format we can work with (abstract syntax tree).
// Optimize the plan (apply optimizations).
// Run operators based on the optimized plan.
Suggested change
// turn raw bytes to substrait plan
// parse substrait plan to in memory format we can work with (abstract syntax tree)
// optimize the plan (apply optimizations)
// run operators based on the optimized plan
//
// Turn raw bytes to substrait plan.
// Parse substrait plan to in-memory format we can work with (abstract syntax tree).
// Optimize the plan (apply optimizations).
// Run operators based on the optimized plan.

Copilot uses AI. Check for mistakes.
package substrait

// turn raw bytes to substrait plan
// parse substrait plan to in memory format we can work with (abstract syntax tree)
Copy link

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hyphenation "in memory" should be "in-memory" when used as a compound adjective modifying "format".

Suggested change
// parse substrait plan to in memory format we can work with (abstract syntax tree)
// parse substrait plan to in-memory format we can work with (abstract syntax tree)

Copilot uses AI. Check for mistakes.
@MarcoFerreiraPerson MarcoFerreiraPerson merged commit d8317f3 into pre-release Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants