feat: generate test substrait plans & basic parse#36
feat: generate test substrait plans & basic parse#36MarcoFerreiraPerson merged 2 commits intopre-releasefrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds high-level architectural comments to the substrait package, outlining the planned workflow for processing Substrait plans: converting raw bytes to plans, parsing to an AST, optimizing, and executing operators. The comments serve as a roadmap for future implementation.
- Added architectural comments documenting the planned workflow for Substrait plan processing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // turn raw bytes to substrait plan | ||
| // parse substrait plan to in memory format we can work with (abstract syntax tree) | ||
| // optimize the plan (apply optimizations) | ||
| // run operators based on the optimized plan | ||
| // |
There was a problem hiding this comment.
These comments should follow Go documentation conventions: start with a capital letter and end with a period. Additionally, "in memory" should be hyphenated as "in-memory" when used as a compound adjective. The trailing empty comment line (line 7) should be removed as it serves no purpose.
Suggested format:
// Turn raw bytes to substrait plan.
// Parse substrait plan to in-memory format we can work with (abstract syntax tree).
// Optimize the plan (apply optimizations).
// Run operators based on the optimized plan.| // turn raw bytes to substrait plan | |
| // parse substrait plan to in memory format we can work with (abstract syntax tree) | |
| // optimize the plan (apply optimizations) | |
| // run operators based on the optimized plan | |
| // | |
| // Turn raw bytes to substrait plan. | |
| // Parse substrait plan to in-memory format we can work with (abstract syntax tree). | |
| // Optimize the plan (apply optimizations). | |
| // Run operators based on the optimized plan. |
| package substrait | ||
|
|
||
| // turn raw bytes to substrait plan | ||
| // parse substrait plan to in memory format we can work with (abstract syntax tree) |
There was a problem hiding this comment.
The hyphenation "in memory" should be "in-memory" when used as a compound adjective modifying "format".
| // parse substrait plan to in memory format we can work with (abstract syntax tree) | |
| // parse substrait plan to in-memory format we can work with (abstract syntax tree) |
5806493 to
c25fdec
Compare
No description provided.