Clarifying edits to User Guide#48
Merged
Ricks-Lab merged 1 commit intoRicks-Lab:masterfrom Oct 12, 2019
csecht:patch-18
Merged
Conversation
para 16: fixed typo para 24: I've added the latest Kernel version as being tested, but you should edit as appropriate. para 66: fixed typo Throughout the Guide I've changed 'p-state' to 'P-state' because this seems to be the accepted usage from what I see on-line. I think previously I recommended changes in the other direction, but I promise no more flip-flops. para 258: Delete "At the moment" from sentence because there are no plans to launch the terminal process at startup (and b/c such a thing is frowned upon in Linux for security reasons.) para 351: Deleted sentence, "Such changes....", because in recent amdgpu-pac versions, I haven't seen fan PWM change without specifically instructing it to do so. Retain the sentence if you've experienced otherwise. para 355: added some words for added clarity (I hope) para 357: fixed typo para 426: I've also seen card # change following driver updates and restarts.
Owner
|
I have modified to: I have tested it with kernel releases no older than 4.15. There have been amdgpu features |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
para 16: fixed typo
para 24: I've added the latest Kernel version as being tested, but you should edit as appropriate.
para 66: fixed typo
Throughout the Guide I've changed 'p-state' to 'P-state' because this seems to be the accepted usage from what I see on-line. I think previously I recommended changes in the other direction, but I promise no more flip-flops.
para 258: Delete "At the moment" from sentence because there are no plans to launch the terminal process at startup (and b/c such a thing is frowned upon in Linux for security reasons.)
para 351: Deleted sentence, "Such changes....", because in recent amdgpu-pac versions, I haven't seen fan PWM change without specifically instructing it to do so. Retain the sentence if you've experienced otherwise.
para 355: added some words for added clarity (I hope)
para 357: fixed typo
para 426: I've also seen card # change following driver updates and restarts.