[WEB-54]: add epac asset attributions#388
Merged
riddim-developer-bot[bot] merged 1 commit intoMay 8, 2026
Merged
Conversation
|
Symphony expected a reviewer-bot review for the current autonomous PR head within the configured SLA window, but none was found.
|
There was a problem hiding this comment.
ReviewAutonomousPR
- Verdict:
approve - Reviewer boundary:
review_only - Acceptance criteria coverage: covered=4, missing=0, unclear=1
Summary
Clean, focused PR that completes WEB-54's remaining compliance work. LICENSE copyright holder correctly updated to 'Riddim Software Inc.' and ATTRIBUTIONS.md properly documents the three non-MIT third-party assets (Cooper Hewitt OFL fonts, Apple App Store badge, House of Commons open-data fixtures). All referenced paths verified to exist in the repo. No code or build files modified.
Actionable findings
- nit — OGL Canada reference URL points to Dept of Finance T&C, not the canonical OGL page (
ATTRIBUTIONS.md:36)- The 'Government of Canada open-data attribution' section links to https://www.canada.ca/en/department-finance/corporate/terms-conditions.html which is the Department of Finance terms-and-conditions page. The canonical Open Government Licence – Canada URL is https://open.canada.ca/en/open-government-licence-canada. The current link will confuse anyone trying to verify the licence terms.
- nit — House of Commons fixtures section does not name the specific Open Parliament Licence (
ATTRIBUTIONS.md:24)- The House of Commons data is governed by the 'Open Parliament Licence' (https://www.ourcommons.ca/en/open-data/licence), which is distinct from the Open Government Licence – Canada referenced in the section below. ATTRIBUTIONS.md currently says to treat the fixtures as 'House of Commons source data' without naming the licence. A direct link to https://www.ourcommons.ca/en/open-data/licence and naming 'Open Parliament Licence' would make the attribution unambiguous and aid future auditors.
Acceptance criteria coverage
- covered — LICENSE file at repo root contains the standard MIT text with copyright holder 'Riddim Software Inc.'
- Verified at HEAD SHA 36203ab: LICENSE is standard MIT text; copyright line reads 'Copyright (c) 2026 Riddim Software Inc.' — single-character change from the prior 'Riddim Software' string.
- covered — GitHub recognizes the license (visible in repo home page sidebar as 'MIT License')
- The license body is the verbatim OSI MIT text; GitHub's license detector matches on body content, not the copyright line. The change does not affect detectability.
- covered — Asset audit performed: walk the repo and flag any third-party asset that is NOT MIT-compatible
- ATTRIBUTIONS.md identifies Cooper Hewitt fonts (SIL OFL), Apple App Store badge (Apple marketing licence), and House of Commons open-data fixtures (Open Parliament Licence / OGL-Canada). All three paths were confirmed to exist in the repo: ios/epac/Fonts/.otf (14 files), website/app-store.svg, ios/epacTests/fixtures/.XML and Members*.csv.
- covered — If incompatible assets exist: add ATTRIBUTIONS.md listing them with their licenses
- ATTRIBUTIONS.md added at repo root. Each entry includes path glob, source, licence terms summary, and a reference URL. The file also adds a general OGL-Canada attribution note for project-authored content derived from Government of Canada sources.
- unclear — If no blocker assets: planning comment on the Linear ticket recording the audit summary
- The PR description states the asset audit found no blockers (all assets are either SIL OFL, Apple marketing licence, or open-government data — none prevent MIT release). However, the acceptance criteria requires a planning comment on the Linear ticket (WEB-54) recording the audit summary. The PR description covers this narratively but it is not possible to confirm the Linear comment was posted from the diff alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
WEB-54 is still active, but
epachad drifted from the original ticket assumptions:mainalready contains a rootLICENSE, yet the copyright holder was still the genericRiddim Softwarestring and the repo bundled several non-MIT third-party assets without an explicit attribution note. This PR finishes the ticket's remaining compliance work by aligning the MIT holder name with the requested legal entity and documenting the separate terms that still apply to bundled assets.What changed
LICENSEcopyright line toRiddim Software Inc.ATTRIBUTIONS.mdfor bundled third-party assets that are not covered by the repo MIT grantTrade-offs not taken
Test plan
LICENSEremains standard MIT text with only the copyright holder line changedATTRIBUTIONS.mdand verify each listed path exists in the repoResolves WEB-54