[EPAC-1919]: Remove LiveParliamentService and live-status UI surfaces#461
Merged
riddim-developer-bot[bot] merged 3 commits intoMay 17, 2026
Conversation
Deletes the live-parliament-status feature from the iOS app as part of the Aurora teardown cost-win (parent project: epac: Retire Aurora). Files deleted: - ios/epac/Util/LiveParliamentService.swift - ios/epac/Domain/Entities/LiveParliamentStatus.swift - ios/epac/Domain/Entities/HomeLiveCardDecision.swift - ios/epac/Domain/UseCases/RefreshLiveParliamentStatus.swift - ios/epacTests/LiveParliamentServiceTests.swift Files simplified: - HomeFeedView.swift: removed live-card switch block, polling loop, refreshLiveParliamentStatus(), and all live-badge helpers - LoadHomeFeed.swift: removed LiveParliamentStatusFetching dependency and computeLiveCardDecision logic - HomeFeedSnapshot.swift: removed liveParliamentStatus/liveCardDecision fields - Ports.swift: removed LiveParliamentStatusFetching protocol - ServicePortsAdapters.swift: removed LiveParliamentService conformance - AppEnvironment.swift: removed debugLiveStatusFixtureIsPresent flag - LoadHomeFeedTests.swift: removed MockLiveParliamentStatusFetching - en.lproj/Localizable.strings, fr.lproj/Localizable.strings: removed all home.live.* keys
|
Symphony expected a reviewer-bot review for the current autonomous PR head within the configured SLA window, but none was found.
|
Per the catalog update rule, remove LiveParliamentService and HomeFeedView from the FetchLiveParliamentStatus entry. The backend live-status Lambda still exists; the iOS client was removed in EPAC-1919. Re-introduction is tracked in EPAC-1928.
There was a problem hiding this comment.
ReviewAutonomousPR
- Verdict:
approve - Reviewer boundary:
review_only - Acceptance criteria coverage: covered=0, missing=0, unclear=0
Summary
All acceptance criteria are met: LiveParliamentService and its full dependency chain (entity, use case, port, adapter, tests, localization keys) are cleanly deleted with zero remaining references. LoadHomeFeedTests pass after mock removal. One unrelated file in a guarded glob was swept into the PR, and one orphaned protocol method is noted but acknowledged.
Actionable findings
- risk / follow_up — Unrelated backend debug workflow deleted in a guarded glob (
.github/workflows/debug.yml).github/workflows/debug.ymlis listed in the repo's guarded globs (.github/workflows/**) and is completely unrelated to the iOS live-status removal. The file is clearly a throwaway debug test (unconditionalt.Fail(), inline Go source, PostgreSQLts_headlineprobe) that belongs inbackend/search/, not in CI. Its deletion is harmless and arguably overdue, but bundling it into a scoped iOS-only PR violates the single-reason-to-change rule and bypasses the guarded-glob review intent. File a follow-up to document why it was deleted or prune any similar stale debug workflows through a dedicated CI-hygiene PR.- Actionability:
follow_up
- nit / follow_up — fetchHansards(between:and:) is now a dead protocol method with no callers (
ios/epac/Domain/Ports/Ports.swift)- The PR description correctly identifies that
fetchHansards(between:and:)onHomeFeedRepositoryhas no remaining call sites afterpostSittingHansardlogic was removed fromLoadHomeFeed. The protocol method (and its conforming implementations) is dead code. The PR chose to leave it to avoid a potentially breaking protocol surface change, which is a reasonable short-term trade-off. File a follow-up to prune the method from the protocol and all conformances before it confuses the next implementer. - Actionability:
follow_up
- The PR description correctly identifies that
Acceptance criteria coverage
- Not explicitly assessed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Part of the Aurora teardown (parent project: epac: Retire Aurora). The `/api/v1/live` endpoint (rate-limited 2 req/min) is being retired for cost savings. The live Parliament status feature is acceptable to remove now; re-introduction is tracked in EPAC-1928.
What changed
grep check: `grep -r -i 'live.parliament|liveParliament|LiveParliamentStatus|liveCardDecision|HomeLiveCard' ios/epac/ --include=".swift"` returns zero results.
Re-introduction of live status is tracked in EPAC-1928.
Trade-offs not taken
Test plan
Screenshots
Not applicable — live-status card is removed entirely; Home tab still renders the `todaySection` with sitting/adjourned/not-sitting status.
Resolves EPAC-1919
Release-Note: Removed live Parliament status card from Home feed (feature retirement; will return in a future update)
Reviewer-Boundary: review-only