Skip to content

Fix AWS profile handling for TestFlight release manifest #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunnypurewal merged 1 commit into from
May 18, 2026
Merged

Fix AWS profile handling for TestFlight release manifest #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/workflows/staging-testflight-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,6 @@ jobs:
bundle config set path vendor/bundle
bundle install --jobs 4 --retry 3

- name: Clear runner AWS profile overrides
if: ${{ !inputs.dry_run }}
run: |
echo "AWS_PROFILE=" >> "$GITHUB_ENV"
echo "AWS_DEFAULT_PROFILE=" >> "$GITHUB_ENV"

- name: Configure AWS credentials via OIDC
if: ${{ !inputs.dry_run }}
uses: aws-actions/configure-aws-credentials@v4
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/testflight-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,6 @@ jobs:
bundle config set path vendor/bundle
bundle install --jobs 4 --retry 3

- name: Clear runner AWS profile overrides
if: ${{ !inputs.dry_run }}
run: |
echo "AWS_PROFILE=" >> "$GITHUB_ENV"
echo "AWS_DEFAULT_PROFILE=" >> "$GITHUB_ENV"

- name: Configure AWS credentials via OIDC
if: ${{ !inputs.dry_run }}
uses: aws-actions/configure-aws-credentials@v4
Expand Down
10 changes: 10 additions & 0 deletions scripts/ci/emit_release_manifest.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,21 @@ GIT_SHA="${GIT_SHA:?}"
WORKFLOW_RUN_ID="${WORKFLOW_RUN_ID:?}"
S3_BUCKET_PREFIX="${S3_BUCKET_PREFIX:?}"

clean_aws_profiles() {
if [[ -z "${AWS_PROFILE//[[:space:]]/}" ]]; then
unset AWS_PROFILE
fi
if [[ -z "${AWS_DEFAULT_PROFILE//[[:space:]]/}" ]]; then
unset AWS_DEFAULT_PROFILE
fi
}

UPLOADED_AT="$(date -u +%Y-%m-%dT%H:%M:%S.000Z)"
MANIFEST_FILE="release-manifest.json"
PREV_MANIFEST_FILE="previous-manifest.json"

# Idempotency: if a manifest already exists for this SHA, reuse it.
clean_aws_profiles
if aws s3 cp "${S3_BUCKET_PREFIX}/${GIT_SHA}.json" "${MANIFEST_FILE}" 2>/dev/null; then
echo "Manifest already exists for SHA ${GIT_SHA}. Re-uploading (idempotent)."
aws s3 cp "${MANIFEST_FILE}" "${S3_BUCKET_PREFIX}/${GIT_SHA}.json"
Expand Down
Loading