[EPAC-1988]: reduce LobbyistService parser complexity#547
Merged
riddim-developer-bot[bot] merged 2 commits intoMay 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
LobbyistService.swifthad three cyclomatic complexity violations in ZIP parsing, CSV row parsing, and communication mapping. This PR decomposes those branches without changing the publicLobbyistServiceAPI.What changed
LobbyistServiceTestscovering quoted fields, embedded commas, embedded newlines, escaped quotes, empty fields, CRLF rows, and skip-header behavior.Trade-offs not taken
Test plan
swiftlint lint --strict --only-rule cyclomatic_complexity ios/epac/Util/LobbyistService.swift— passed, 0 violations.swiftlint --strict ios/epacTests/LobbyistServiceTests.swift— passed, 0 violations.cd ios && make build— passed; Xcode emitted existing Swift macro redundantSendablewarnings.python3 scripts/localization/check_localizations.py --github-warnings— exited 0; reported existing missingonboarding.welcome.titlelocalization warnings.cd ios && make test— built and ran, but failed on existing snapshot baseline mismatches; newLobbyistServiceTestsexecuted, with one CRLF assertion exposing a parser edge case that this PR then fixed.xcodebuild test ... -skip-testing:epacTests/SnapshotTests -skip-testing:epacUITests— newLobbyistServiceTestspassed; command still failed on existing unrelatedFollowPreferenceAdapterTests.savedMemberNameReflectsPostalCodeStorestate leakage.Reviewer-Boundary: review-only
Resolves EPAC-1988