Skip to content

[codex] Fix lobbyist organization detail loading#766

Merged
riddim-developer-bot[bot] merged 1 commit into
mainfrom
codex/lobbying-org-detail-blank
Jun 8, 2026
Merged

[codex] Fix lobbyist organization detail loading#766
riddim-developer-bot[bot] merged 1 commit into
mainfrom
codex/lobbying-org-detail-blank

Conversation

@riddim-developer-bot
Copy link
Copy Markdown
Contributor

Scope

Fixes the blank Lobbyist Organization detail page reached from Accountability > Lobbyist Organizations.

Root cause: LobbyistOrganizationView initially rendered no body when profile == nil, isLoading == false, and loadFailed == false. Because the .task modifier was attached to that empty conditional body, the async profile load never started after navigation. The view now renders a loading state until either the profile or error state is available.

This also adds a committed XCUITest that walks the staging-backed flow from the Accountability hub to the Lobbyist Organizations directory, taps Canadian Chamber of Commerce, and asserts the profile screen loads.

Bugfix SPEC

  • Spec: Local validated intake SPEC at .factory/intake/20260608-143539-lobbyist-organization-detail-opens-blank/SPEC.md.
  • Trace ID: BUGFIX-20260608-143539-49d9d3b4

Testing notes

  • Automated tests run:
    • xcodebuild test -project ios/epac.xcodeproj -scheme epac -destination 'platform=iOS Simulator,id=A42F2FBA-FC7A-4EFF-8F85-C402A8850ED6' -derivedDataPath ios/.build -only-testing:epacUITests/epacUITests/testAccountabilityTab_LobbyistOrganizationDetailLoads -resultBundlePath ios/.build/LobbyistOrganizationDetail.xcresult | xcbeautify
    • swiftlint --strict ios/epac/Views/Accountability/LobbyistOrganizationView.swift ios/epacUITests/epacUITests.swift
    • git diff --check
    • python3 scripts/intake/bugfix_spec.py validate .factory/intake/20260608-143539-lobbyist-organization-detail-opens-blank/SPEC.md
  • Manual verification: Verified the passing XCUITest attachment on iPhone 17 Pro simulator shows the Canadian Chamber of Commerce profile with registration history.

Screenshots

Passing XCUITest screenshot exported locally from ios/.build/LobbyistOrganizationDetail.xcresult:

/tmp/lobbying-detail-attachments/46CFEFD5-0249-4B12-A888-6E409A57B17E.png

The screenshot shows the Canadian Chamber of Commerce detail page loaded after tapping the directory row.

Related issue

  • Closes: N/A

Release-Note: Fixes blank Lobbyist Organization detail pages when opening an organization from the directory.

@riddim-developer-bot riddim-developer-bot Bot enabled auto-merge (squash) June 8, 2026 14:53
@riddim-developer-bot riddim-developer-bot Bot merged commit 24cbabb into main Jun 8, 2026
7 of 8 checks passed
@riddim-developer-bot riddim-developer-bot Bot deleted the codex/lobbying-org-detail-blank branch June 8, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant