[codex] Fix lobbyist organization detail loading#766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Fixes the blank Lobbyist Organization detail page reached from Accountability > Lobbyist Organizations.
Root cause:
LobbyistOrganizationViewinitially rendered no body whenprofile == nil,isLoading == false, andloadFailed == false. Because the.taskmodifier was attached to that empty conditional body, the async profile load never started after navigation. The view now renders a loading state until either the profile or error state is available.This also adds a committed XCUITest that walks the staging-backed flow from the Accountability hub to the Lobbyist Organizations directory, taps Canadian Chamber of Commerce, and asserts the profile screen loads.
Bugfix SPEC
.factory/intake/20260608-143539-lobbyist-organization-detail-opens-blank/SPEC.md.Testing notes
xcodebuild test -project ios/epac.xcodeproj -scheme epac -destination 'platform=iOS Simulator,id=A42F2FBA-FC7A-4EFF-8F85-C402A8850ED6' -derivedDataPath ios/.build -only-testing:epacUITests/epacUITests/testAccountabilityTab_LobbyistOrganizationDetailLoads -resultBundlePath ios/.build/LobbyistOrganizationDetail.xcresult | xcbeautifyswiftlint --strict ios/epac/Views/Accountability/LobbyistOrganizationView.swift ios/epacUITests/epacUITests.swiftgit diff --checkpython3 scripts/intake/bugfix_spec.py validate .factory/intake/20260608-143539-lobbyist-organization-detail-opens-blank/SPEC.mdScreenshots
Passing XCUITest screenshot exported locally from
ios/.build/LobbyistOrganizationDetail.xcresult:/tmp/lobbying-detail-attachments/46CFEFD5-0249-4B12-A888-6E409A57B17E.pngThe screenshot shows the Canadian Chamber of Commerce detail page loaded after tapping the directory row.
Related issue
Release-Note: Fixes blank Lobbyist Organization detail pages when opening an organization from the directory.