[EVI-8]: add capture-pr examples and fixtures#40
Conversation
EVI-8 Add examples docs and test fixtures for capture-pr
Context / backgroundParent Project: Evidence PR Change Proof MVP ( Acceptance criteria
External validation gatesNone. Human acceptance for the whole MVP is consolidated in the Project-level human handoff issue. Out of scope
Inputs / dependenciesBlocked by: Target repository: Existing files to inspect:
Documentation should use Risks / notes for implementer
Definition of DoneDone when a new consuming repo maintainer can read the README, copy an example workflow and plan, understand the app-side harness requirement, and know how to debug the most common failures without asking the Evidence team. Architecture ImpactDocumentation/examples only. They should reflect the architecture created by earlier issues rather than introducing new runtime behavior. Clean Architecture ShapeUse case:
Entities / value objects:
Ports:
Adapters:
Boundary rule:
Catalog update:
Mergeability / change ownershipSingle reason to change: document and fixture the completed |
There was a problem hiding this comment.
ReviewAutonomousPR
- Verdict:
approve - Reviewer boundary:
review_only - Acceptance criteria coverage: covered=9, missing=0, unclear=0
Summary
PR satisfies the EVI-8 documentation and fixture acceptance criteria. The sample plan is generic and parse-tested, the capture-pr workflow exists and is actionlint-covered, README/troubleshooting cover the MVP limits and common failures, and GitHub checks report swift-test and actionlint success.
Actionable findings
- None.
Acceptance criteria coverage
- covered — README explains capture-pr use case with before/after screenshots, videos, manifest, and report.
- README now describes reviewer-oriented before/after PR evidence and lists the expected output artifacts.
- Actionability:
none - Evidence: README.md Pull Request Change Evidence section
- covered — README includes a local CLI example and a GitHub Action example.
- README includes both a multiline local
evidence capture-prinvocation and an iOS GitHub Actions example using the composite action. - Actionability:
none - Evidence: README.md capture-pr CLI and CI examples
- README includes both a multiline local
- covered — README documents MVP limitation requiring an app-side XCTest Evidence harness for arbitrary UI actions.
- README explicitly distinguishes launch-only simctl support from arbitrary UI actions requiring
runner = "xctest"plus an app-side harness. - Actionability:
none - Evidence: README.md Pull Request Change Evidence section
- README explicitly distinguishes launch-only simctl support from arbitrary UI actions requiring
- covered — Examples/ contains a sample PR evidence plan JSON file with at least two steps.
Examples/pr-change-evidence-plan.jsoncontains a generic simctl plan with six steps.- Actionability:
none - Evidence: Examples/pr-change-evidence-plan.json
- covered — Examples/workflows/ contains final capture-pr-on-pr.yml workflow or updates existing one.
- The head revision contains
Examples/workflows/capture-pr-on-pr.yml; this PR also keeps tests asserting its expected copy-pasteable shape. - Actionability:
none - Evidence: Examples/workflows/capture-pr-on-pr.yml and ExampleWorkflowsTests
- The head revision contains
- covered — docs/troubleshooting.md includes common capture-pr failure cases.
- Troubleshooting now covers old SHAs, simulator availability, missing XCTest harness, missing ImageMagick, missing ffmpeg, missing GitHub token, and empty artifact outputs.
- Actionability:
none - Evidence: docs/troubleshooting.md
- covered — Tests assert sample plans and workflows stay parseable and actionlint-compatible.
- Tests load the sample PR plan through
PRChangeEvidencePlan.loadand run actionlint over example workflows when actionlint is installed; CI also reports actionlint success. - Actionability:
none - Evidence: Tests/EvidenceCLIKitTests/ExampleWorkflowsTests.swift; PR status checks
- Tests load the sample PR plan through
- covered — No generated app-specific screenshots, videos, or EPAC-only plans are committed.
- Changed files are docs, tests, a generic JSON fixture, and examples only; no binary/generated evidence artifacts or EPAC-specific plans were added.
- Actionability:
none - Evidence: PR file list
- covered — swift test passes.
- GitHub status check
build-and-testpassed for the PR head SHA. - Actionability:
none - Evidence: PR statusCheckRollup for f9d86ba
- GitHub status check
Reviewer-Boundary: review-only
Summary
Examples/pr-change-evidence-plan.jsonfixture forcapture-prusing the launch-only simctl runner.Verification
swift build— passed.swift test— passed: 120 tests, 0 failures, 2 skipped because node was not found for optional web integration tests.swift test --filter ExampleWorkflowsTests— passed: 5 tests, including plan parsing and actionlint-backed workflow validation.actionlint Examples/workflows/*.yml .github/workflows/*.yml— passed.git diff --check— passed.Notes