Hotfix sync tests #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The enable-sync property test was failing because this property was removed since v1.0.7. The equivalent behaviour of enable-sync=true can be achieved with stream-sync=compensate-ts.
jcaballeros
requested review from
bill9889,
michaelgruner,
mmontero and
rrcarlosrodriguez
rrcarlosrodriguez
approved these changes
Aug 10, 2020
bill9889
approved these changes
Aug 10, 2020
mmontero
requested changes
Aug 11, 2020
tests/check/gst/test_stream_sync.c
Outdated
| GstPipeline *sink1; | ||
| GstPipeline *sink2; | ||
|
|
||
|
|
tests/check/gst/test_stream_sync.c
Outdated
| GstElement *vtsrc1; | ||
| GstElement *vtsrc2; | ||
|
|
||
|
|
tests/check/gst/test_stream_sync.c
Outdated
| src = | ||
| GST_PIPELINE (gst_parse_launch | ||
| ("interpipesrc name=intersrc listen-to=intersink1 block-switch=false allow-renegotiation=true format=3 ! capsfilter caps=video/x-raw,width=[320,1920],height=[240,1080],framerate=(fraction)5/1 ! " | ||
| ("interpipesrc name=intersrc listen-to=intersink1 stream-sync=compensate-ts block-switch=false allow-renegotiation=true format=3 ! capsfilter caps=video/x-raw,width=[320,1920],height=[240,1080],framerate=(fraction)5/1 ! " |
Contributor
There was a problem hiding this comment.
break the line, maximum 79 characters per line
| /* Now change to the first video src and pull another buffer */ | ||
| g_object_set (G_OBJECT (intersrc), "listen-to", "intersink1", NULL); | ||
|
|
||
| outsample = gst_app_sink_pull_sample (GST_APP_SINK (asink)); |
Contributor
There was a problem hiding this comment.
I am guessing this test verifies that interpipes can change between sources and keep a monotonically increasing pipeline, am I right? If so, how can you be sure this sample corresponds to the new source? you are not draining the pipeline before changing sources
mmontero
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.