fix(ui): trim the boot comments after the composeBoot extraction (RIG-2874) - #1104
Merged
trunk-io[bot] merged 1 commit intoSep 11, 2026
Conversation
…-2874) The index.tsx block still narrated construction mechanics that moved into composeBoot, and two module headers ran 6 lines against a 4-line ceiling.
This was referenced Sep 11, 2026
feat(ui): export a composeBoot seam so the analytics/clients boot order is testable (RIG-2874)
#1096
Merged
rigel-mintaka
added this pull request to stack #1098
September 11, 2026 18:51
|
Compass engineering docs preview: https://compass-ui-rig-2874-comment.compass-eng-docs.pages.dev Deployed from |
mattwilkinsonn
approved these changes
Sep 11, 2026
|
This pull request was merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review fixes for #1096, landed additively on top rather than amended into it
(pushed commits are immutable here —
immutable_heads()includesremote_bookmarks()— and review fixes are additive by house rule, so aninterdiff stays visible).
What the review found
Medium — the
index.tsxcomment block went stale on extraction. #1096moved the analytics/clients construction into
composeBoot, but left the~30-line block that narrates it in
main(). After the move there is no getterliteral and no two ordered statements at that location, so the sentence
described code that is no longer there: the "next statement" is now a single
destructuring call. It also duplicated the same forward-reference invariant
already carried in
compose-boot.ts, so changing the order in one file wouldsilently falsify the other.
Trimmed to the call-site facts a reader needs there (analytics off by default;
correlation best-effort in both directions) with a one-line pointer to
composeBootfor the construction order. 30 lines → 6.compose-boot.tsisnow the single owner of the forward-reference explanation.
Low — two module headers over the comment ceiling. The house ceiling is 4
physical lines;
compose-boot.ts:9-14andcompose-boot.test.ts:14-19wereboth 6. Each cut to 3, keeping the why (a wrong order fails only at the
network door, so injectable factories are the only way to pin it) and dropping
the restated mechanics.
Not changed, and why
The review also flagged
expect(built.analytics).toBe(analytics)/expect(built.clients).toBe(clients)as near-padding, on the grounds that thegetter-resolution assertions already prove the wiring. Keeping both: they are
the only assertions that catch a swapped or dropped return, which the
getter assertions do not — those resolve through the captured closures and
pass even if
composeBootreturned the wrong pair.Gates
bun testcompose-boot + analytics + live/client — 30 pass / 0 faillines still gives 0 pass / 1 fail; restored file byte-identical (
cmp)bunx tsc --noEmit(apps/ui) — rc=0bunx biome check(3 files) — rc=0RIG-2874