ci: Refacto of ci and fix warnings #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
.github/workflows/ci.yml:46
- Ensure that GITHUB_REF is always long enough to extract the tag correctly as intended. A guard or a more robust extraction method might prevent generating an empty TAG value if GITHUB_REF is unexpectedly short.
echo "TAG=${GITHUB_REF:10}" >> $GITHUB_ENV
.github/workflows/ci.yml:69
- Confirm that the TAG environment variable is reliably available in the shell context to ensure the correct package version is used during the push. If TAG is missing or empty, the package push could fail or use an incorrect version.
run: dotnet nuget push src/Netatmo/bin/Release/Netatmo.$TAG.nupkg -k ${{ secrets.NUGET_ORG_KEY }} -s https://api.nuget.org/v3/index.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the CI workflow to utilize environment variables for versioning, replace deprecated actions, and split the testing workflow for better clarity and maintainability.