Normalize provider-backed model updates#714
Merged
jaberjaber23 merged 1 commit intoRightNow-AI:mainfrom Mar 20, 2026
Merged
Conversation
Resolve catalog display names and aliases to canonical model IDs when spawning or updating agents, keep provider-specific api_key_env hints in sync when switching providers, and route explicit provider model changes through kernel model normalization instead of directly mutating the registry. This fixes cases like xAI agents carrying stale OpenAI auth hints or UI labels such as 'Grok 4.20' being treated as raw model IDs. (cherry picked from commit 51ee6a5a927208ab0301a29fd2e40b29c9dfaf7d)
jaberjaber23
approved these changes
Mar 19, 2026
Member
jaberjaber23
left a comment
jaberjaber23
left a comment
There was a problem hiding this comment.
Solid fix. Catalog normalization now happens consistently through set_agent_model(). Display-name matching in find_model() is a good addition. Test coverage adequate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Some provider switches left stale auth hints behind, and some UI-visible labels such as Grok 4.20 were being treated as raw model IDs. That caused valid provider/model changes to fail in the daemon even though the selected model existed in the catalog.
Validation