Fix clippy warnings and WhatsApp gateway Node 25 compat#9
Closed
devatsecure wants to merge 1 commit intoRightNow-AI:mainfrom
Closed
Fix clippy warnings and WhatsApp gateway Node 25 compat#9devatsecure wants to merge 1 commit intoRightNow-AI:mainfrom
devatsecure wants to merge 1 commit intoRightNow-AI:mainfrom
Conversation
- Collapse nested else-if blocks in CLI doctor command to satisfy clippy - Add "type": "commonjs" to whatsapp-gateway package.json (Node 25 defaults to ESM) - Replace import.meta.url with __dirname in gateway index.js (import.meta is invalid in CJS) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
Good catch on the Node 25 ESM default change. We'll patch this ourselves. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doctorcommand"type": "commonjs"topackages/whatsapp-gateway/package.json— Node.js 25 defaults to ESM and the gateway usesrequire()import.meta.urlwith__dirnameinpackages/whatsapp-gateway/index.js—import.metais invalid in CommonJS contextTest plan
cargo clippy --workspace --all-targets -- -D warningspasses with zero warningscargo test --workspace— 1,769 tests passhttp://127.0.0.1:50051/🤖 Generated with Claude Code