Conversation
|
Would rather not see the top level readme being duplicated in the file tree (also in Podspec Metadata) |
|
The pod/pods naming might be unnecessarily confusing. Your suggestion of "Sources" is an improvement, but still overlaps all the files in the "Development Pods" directory. I don't have a specific suggestions to allow readme editing without any duplication, though; I'd like more opinions from the rest of the team. |
|
I'm not thrilled about it, but maybe the most straight forward solution (suggested by Chris B) is to combine all of our ReadMes into just the single, top-level one... But I'd also be okay deferring that to another PR, and strip all the file-system stuff out of this one so we can merge your other fixes/updates. |
armcknight
force-pushed
the
chore/armcknight/project-renovations
branch
from
9a0a295 to
8f52002
Compare
|
Hey y'all! Sorry for neglecting this... I removed the folder reference to the pod source directory and top level readme, but left the other config files like podspec and gemfile. I agree about the duplication of the file references in Development Pods with the folder reference... I have an open issue and wip pr to include all subdirectory READMEs in the Pods project as well: armcknight/CocoaPods#1 Let me know if we'd like to move ahead with renaming |
minimusic
left a comment
minimusic
left a comment
There was a problem hiding this comment.
Everything else looks okay to me, not seeing any conflicts (though there are some English.lproj warnings...). I don't have a preference around the pod->sources rename; I'm cool with the change.
armcknight
force-pushed
the
chore/armcknight/project-renovations
branch
from
8f52002 to
4a1ca6f
Compare
helps edit config files like the podspec
armcknight
force-pushed
the
chore/armcknight/project-renovations
branch
2 times, most recently
from
5fd13f9 to
f60ccb1
Compare
- update cocoapods gem to 1.7.0 - update the pod installation in the example project which was several versions behind
armcknight
force-pushed
the
chore/armcknight/project-renovations
branch
from
f60ccb1 to
207698c
Compare
|
Re-tested; still looks good to me! You could add more authors from the repo contributors list, but I'm ambivalent about it. |
3 participants
Just some housekeeping, including adding some file/folder references to Example.xcworkspace, to facilitate authoring of e.g. readmes and config files in Xcode, alongside the Swift sources. That includes a folder reference to
Pod/, to get all the subdirectory readmes, etc.Wasn't sure who all to add to authors, but I started by including myself and folks I've already chatted with for this repo. Other suggestions welcome.