Hairline Fade offset-logging toggle#175
Merged
ZevEisenberg merged 5 commits intomasterfrom Dec 16, 2019
Merged
Conversation
Adding some missing debug functionality for the hairline fade. This incorporates a new toggle to log the offset of the hairline-fader's scrollview while scrolling to allow the implementer to more easily fine tune the hairline's fade range.
Added context to log message
ZevEisenberg
requested changes
Dec 16, 2019
Pod/Classes/Lifecycle/Behaviors/Nav-Bar-Hairline-Fade/NavBarHairlineFadeBehavior.swift
Outdated
Show resolved
Hide resolved
Pod/Classes/Lifecycle/Behaviors/Nav-Bar-Hairline-Fade/NavBarHairlineFadeBehavior.swift
Show resolved
Hide resolved
Pod/Classes/Lifecycle/Behaviors/Nav-Bar-Hairline-Fade/NavBarHairlineFadeBehavior.swift
Outdated
Show resolved
Hide resolved
no functional changes. In this commit i added documentation to better explain the previous functional changes made in this branch. Also tweaked the syntax in the log message to be more helpful. and added a missing whitespace
ZevEisenberg
requested changes
Dec 16, 2019
Pod/Classes/Lifecycle/Behaviors/Nav-Bar-Hairline-Fade/NavBarHairlineFadeBehavior.swift
Show resolved
Hide resolved
Pod/Classes/Lifecycle/Behaviors/Nav-Bar-Hairline-Fade/NavBarHairlineFadeBehavior.swift
Outdated
Show resolved
Hide resolved
Cleaned up some syntax for better documentation, also tweaked some documentation for better understanding.
Pod/Classes/Lifecycle/Behaviors/Nav-Bar-Hairline-Fade/NavBarHairlineFadeBehavior.swift
Outdated
Show resolved
Hide resolved
…irlineFadeBehavior.swift Co-Authored-By: Zev Eisenberg <zeisenberg@rightpoint.com>
Collaborator
|
@needhamwoodj this looks great. Thanks for the PR! Merging once CI finishes |
ZevEisenberg
approved these changes
Dec 16, 2019
ZevEisenberg
deleted the
bugfix/jneedhamwood/Hairline-fade-offset-logging-toggle
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding some missing debug functionality for the hairline fade. This incorporates a new property/toggle in 'NavBarHairlineFadeBehavior' to log the offset of the hairline-fader's scrollview while scrolling to allow the implementer to more easily fine tune the hairline's fade range.
This addresses/closes issue #174