Feat: add validation for profile searching & scoring in utils#22
Merged
corentin-hrflow merged 5 commits intomasterfrom Jun 27, 2024
Merged
Conversation
Thomas65535
requested changes
Jun 26, 2024
Contributor
Thomas65535
left a comment
Thomas65535
left a comment
There was a problem hiding this comment.
@corentin-hrflow
Cas d'usage:
- le développeur à un JSON d'un profil
- il utilise l'objet Profile HrFlow.ai pour valider le format
- il utilise la fonction
is_valid_for_searchingpour valider son profil - il envoi son profil dans la source
Le problème que l'on rencontre actuellement, c'est lorsqu'un développeur (chez nous ou chez le client) souhaite migrer des profils déjà existants vers HrFlow.ai.
NB: L'autre cas, c'est lorsqu'on reçoit des CVs => il y a beaucoup moins de problème car le remplissage est gérée par le Parsing
Thomas65535
requested changes
Jun 26, 2024
Comment on lines
+68
to
+74
| return ( | ||
| is_valid_experiences_for_scoring(profile.experiences) | ||
| or is_valid_educations_for_scoring(profile.educations) | ||
| or bool(profile.summary) | ||
| or bool(profile.skills) | ||
| or bool(profile.tasks) | ||
| ) |
Contributor
There was a problem hiding this comment.
@corentin-hrflow
Il faut que le profile soit searchable pour être scorable, il faut donc ajouter un is_valid_for_searching(...) and ...
Thomas65535
approved these changes
Jun 26, 2024
corentin-hrflow
deleted the
feat/add-scoring-searching-profile-validation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add validation for profile searching and scoring.