Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #60 +/- ##
========================================
Coverage 59.37% 59.37%
========================================
Files 57 57
Lines 1472 1472
Branches 87 87
========================================
Hits 874 874
Misses 598 598 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the compilation on older MSVC 2019 (19.29) by converting two
warnings that were treated as errors back to warnings. This problems doesn't occur
on newer MSVC 2022 and probably is resolved on glog's
masteror in one of themaintained forks (
ng-logor Abseil Logging).For
v1.2.0we should probably update/change the dependency to one of thoseto stay with maintained dependencies.