Skip to content

Fix compilation on MSVC 2019#60

Merged
RippeR37 merged 1 commit intodevelopfrom
test/msvc-2019/1
Apr 22, 2025
Merged

Fix compilation on MSVC 2019#60
RippeR37 merged 1 commit intodevelopfrom
test/msvc-2019/1

Conversation

@RippeR37
Copy link
Copy Markdown
Owner

@RippeR37 RippeR37 commented Apr 22, 2025

This commit fixes the compilation on older MSVC 2019 (19.29) by converting two
warnings that were treated as errors back to warnings. This problems doesn't occur
on newer MSVC 2022 and probably is resolved on glog's master or in one of the
maintained forks (ng-log or Abseil Logging).

For v1.2.0 we should probably update/change the dependency to one of those
to stay with maintained dependencies.

@RippeR37 RippeR37 self-assigned this Apr 22, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.37%. Comparing base (b981622) to head (73cf093).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #60   +/-   ##
========================================
  Coverage    59.37%   59.37%           
========================================
  Files           57       57           
  Lines         1472     1472           
  Branches        87       87           
========================================
  Hits           874      874           
  Misses         598      598           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RippeR37 RippeR37 changed the title Attempt to fix compilation on MSVC 2019 Fix compilation on MSVC 2019 Apr 22, 2025
@RippeR37 RippeR37 merged commit dd77904 into develop Apr 22, 2025
46 checks passed
@RippeR37 RippeR37 deleted the test/msvc-2019/1 branch April 22, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant