Skip to content

Class Compile Hierarchy - Doesn't account for parent class include file changes#466

Closed
kenherring-rkt wants to merge 1 commit into
Riverside-Software:masterfrom
kenherring-rkt:check-hierarchy-includes
Closed

Class Compile Hierarchy - Doesn't account for parent class include file changes#466
kenherring-rkt wants to merge 1 commit into
Riverside-Software:masterfrom
kenherring-rkt:check-hierarchy-includes

Conversation

@kenherring-rkt
Copy link
Copy Markdown
Contributor

Description

When compiling incrementally child classes which reference temp-tables defined in an include which was referenced by the parent class, the child class fails to compile.

Fixes #455

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My branch is started from the latest commit in master
  • My commit history is clean
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@kenherring-rkt
Copy link
Copy Markdown
Contributor Author

A few quick notes:

  • I do not believe any documentation changes are required.
  • I was only able to test with 12.2. There are some unit tests which I cannot run because of this, however, this change doesn't appear to affect any of the unit tests that I am able to run successfully.

Please review. I'm happy to make any suggested improvements. 😎

@kenherring-rkt kenherring-rkt marked this pull request as ready for review January 4, 2022 19:56
@gquerret
Copy link
Copy Markdown
Contributor

gquerret commented Feb 1, 2022

@kenherring-rkt I just see this PR is still open. I won't be able to have a look at it in the coming days, but hopefully I'll be able to do that at the end of February.

@kenherring-rkt
Copy link
Copy Markdown
Contributor Author

That's fine with me. Thank you.

@gquerret gquerret force-pushed the check-hierarchy-includes branch from e9074b5 to a11f971 Compare September 16, 2022 10:13
@gquerret gquerret closed this Sep 16, 2022
@gquerret
Copy link
Copy Markdown
Contributor

I didn't expect it would take so long... Thank you for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Class Compile Hierarchy - Doesn't account for parent class include file changes

2 participants