fix: redraw on terminal resize#102
Merged
RivoLink merged 1 commit intoRivoLink:mainfrom May 8, 2026
Merged
Conversation
RivoLink
reviewed
May 8, 2026
| if sync_render_width(terminal, app, ss, themes)? { | ||
| needs_redraw = true; | ||
| } | ||
| let _width_changed = sync_render_width(terminal, app, ss, themes)?; |
Owner
There was a problem hiding this comment.
Just call sync_render_width directly.
Owner
|
Hi @andyraitra, I just have a few suggestions:
GPG signing docs : https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits Thanks again for your interest! |
Owner
|
I did a merge, so you need to rebase on main as well. |
be91b7a to
71fd619
Compare
71fd619 to
62418bf
Compare
Contributor
Author
|
Done! Removed the _width_changed variable, rebased on main, and signed the commit. |
Owner
|
Perfect, thank you 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #90
What changed
Why it changed
Before this change, resizing only the terminal height could leave the screen stale because redraw happened only when width changed.
How it was tested
env -u LEAF_EDITOR -u VISUAL -u EDITOR cargo testcargo clippy --all-targets --all-features -- -D warningscargo build --releasecargo run -- TESTING.md