Skip to content

Conversation

@xgonsen1
Copy link

No description provided.

@xgonsen1
Copy link
Author

@himdel @ZitaNemeckova please review

@ZitaNemeckova
Copy link
Contributor

ZitaNemeckova commented Dec 1, 2019

  • update your branch & resolve conflicts (hint: rebase) (20%)

  • reorder commits so that next class-related commits(questions 3, 5, 7) are together (10%)

  • squash next class-related commits into one (hint: you should use two s not three) (20%)

  • delete commit with question 1 (10%)

  • rename commits about your previous experience with Git (questions 2, 4) to be in UPERCASE (hint: you do not rename the commit at the same time as you write r but later) (20%)

  • edit commit that mentions SVN so answer is Noooooooooooo or Yesssssssssss (hint: you have to add changed file and amend commit) (20%)

@ZitaNemeckova ZitaNemeckova mentioned this pull request Dec 2, 2019
@himdel
Copy link
Contributor

himdel commented Dec 20, 2019

Final score = 100%

@himdel himdel closed this Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants