use right value instead of copy value in c++ interface#320
Merged
lemire merged 2 commits intoRoaringBitmap:masterfrom Sep 8, 2021
Merged
use right value instead of copy value in c++ interface#320lemire merged 2 commits intoRoaringBitmap:masterfrom
lemire merged 2 commits intoRoaringBitmap:masterfrom
Conversation
Member
|
I like it a lot, but I'd like an independent review before merging. @Oppen would you have a look? It short. |
Collaborator
|
It seems |
Contributor
Author
|
@Oppen Applied |
Collaborator
|
LGTM! |
Member
|
This is nice. Merging. |
morningman
pushed a commit
to apache/doris
that referenced
this pull request
Mar 17, 2022
update Croaring for good performance, according to RoaringBitmap/CRoaring#320
morningman
pushed a commit
to apache/doris
that referenced
this pull request
Mar 17, 2022
update Croaring for good performance, according to RoaringBitmap/CRoaring#320
morningman
pushed a commit
to apache/doris
that referenced
this pull request
Mar 17, 2022
update Croaring for good performance, according to RoaringBitmap/CRoaring#320
zhengte
pushed a commit
to zhengte/incubator-doris
that referenced
this pull request
Mar 20, 2022
update Croaring for good performance, according to RoaringBitmap/CRoaring#320
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use move instead of copy in c++ interface which will get good performance under sparse bitmap
StarRocks/starrocks#86