C++ Wrapper for Roaring32 *Bulk#492
Merged
lemire merged 4 commits intoRoaringBitmap:masterfrom Jun 18, 2023
Merged
Conversation
mapleFU
force-pushed
the
cpp-wrapper-add-bulk
branch
from
5a67ed4 to
02cd788
Compare
Contributor
Author
|
@lemire I've add a basic implemention, would you mind take a look? |
mapleFU
force-pushed
the
cpp-wrapper-add-bulk
branch
from
02cd788 to
9e037c0
Compare
lemire
reviewed
Jun 15, 2023
lemire
reviewed
Jun 15, 2023
Member
|
@mapleFU Please consider my comments. I am not asking for changes, just that you consider my comments. |
mapleFU
force-pushed
the
cpp-wrapper-add-bulk
branch
from
43b1680 to
963c253
Compare
mapleFU
commented
Jun 16, 2023
mapleFU
changed the title
roaring_bitmap_add_bulk*Bulk
Dr-Emann
reviewed
Jun 16, 2023
Dr-Emann
approved these changes
Jun 17, 2023
Member
|
Running tests. |
Member
|
Will be part of the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds:
BulkContextWrapperas a wrapper forapi::roaring_bulk_context_taddBulk, as a wrapper forapi::roaring_bitmap_add_bulkI'm not so familiar with C++ wrapper, but I'm glad to learn and resolve the problems in my code