Skip to content

Define __EXTENSIONS__ on illumos#498

Merged
lemire merged 1 commit intoRoaringBitmap:masterfrom
jasonbking:master
Jul 18, 2023
Merged

Define __EXTENSIONS__ on illumos#498
lemire merged 1 commit intoRoaringBitmap:masterfrom
jasonbking:master

Conversation

@jasonbking
Copy link
Copy Markdown
Contributor

This allows the core library to build on illumos (the C++ benchmarks don't build due to a different issue surrounding the use of the restrict keyword that I can file).

@lemire
Copy link
Copy Markdown
Member

lemire commented Jul 18, 2023

Can you explain this PR? I am not sure that I understand.

@jasonbking
Copy link
Copy Markdown
Contributor Author

There's apparently a bug on illumos platforms that prevents the various int macros (PRIu32, etc) from being visible when using _XOPEN_SOURCE 700 (I'm still waiting for feedback to confirm this, though my suspicion it is).

Unless you only ever want the exact set of symbols defined by a particular POSIX or X/Open standard, defining __EXTENSIONS__ gives you all the things you typically expect that aren't strictly in either standard, but are still largely universal.

@lemire
Copy link
Copy Markdown
Member

lemire commented Jul 18, 2023

Merging.

@lemire lemire merged commit aa5377b into RoaringBitmap:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants