Remove slow assertReadableFile() check

[staabm]

this line showed up in my profilling and I realized most call-sites already do file-IO on the given filename before creating a LocatedSource, e.g.

• BetterReflection/src/SourceLocator/Type/AnonymousClassObjectSourceLocator.php

  Line 123 in 6b5cd7f

  $fileContents = file_get_contents($fileName);

• BetterReflection/src/SourceLocator/Type/AutoloadSourceLocator.php

  Lines 90 to 103 in 6b5cd7f

  	if (strtolower($identifier->getName()) !== strtolower($locatedData['name'])) {
  	return new AliasLocatedSource(
  	file_get_contents($locatedData['fileName']),
  	$locatedData['name'],
  	$locatedData['fileName'],
  	$identifier->getName(),
  	);
  	}
  	return new LocatedSource(
  	file_get_contents($locatedData['fileName']),
  	$identifier->getName(),
  	$locatedData['fileName'],
  	);

• BetterReflection/src/SourceLocator/Type/SingleFileSourceLocator.php

  Lines 46 to 50 in 6b5cd7f

  	return new LocatedSource(
  	file_get_contents($this->fileName),
  	$identifier->getName(),
  	$this->fileName,
  	);

[Ocramius]

Worth using realpath here?

[staabm]

I did not find a single place where we pass in filename, but did not already do IO on the path, like e.g. file_get_contents.
I think this check here is useless.

we could hide it behand a if(zend-assertions-enabled) switch or similar, if you prefer.

I don't get why realpath() would be different then what we have right now?

[Ocramius]

This API is public, so yah, some invariant checking would be expected.

[Ocramius]

Ah, never mind, it's @internal

I'll 🚢 as-is, thanks @staabm!

[staabm]

Thank you 🙏

[Ocramius]

Ah, never mind, it's @internal

I'll 🚢 as-is, thanks @staabm!