Skip to content

Conversation

@TokyoSU
Copy link
Contributor

@TokyoSU TokyoSU commented Jul 5, 2022

(This PR come from #198)
This is not finished, i will add more later :)
PS: you can also check the progress here.

@RobLoach RobLoach changed the title Add default constructor for class Add default constructors for BoundingBox and Model Jul 8, 2022
@RobLoach
Copy link
Owner

RobLoach commented Jul 8, 2022

I think this is pretty good to merge as is 😉

@TokyoSU
Copy link
Contributor Author

TokyoSU commented Jul 8, 2022

not really, there is more like window, audio etc.. that need it too

EDIT:
do you think changing bool to void would change something ? like:

bool Init(int width = 800, int height = 450, const std::string& title = "raylib") {
    ::InitWindow(width, height, title.c_str());
    if (!IsWindowReady()) {
        throw RaylibException("Failed to create Window");
    }
    return IsWindowReady();
}

to

void Init(int width = 800, int height = 450, const std::string& title = "raylib") {
    ::InitWindow(width, height, title.c_str());
    if (!IsWindowReady()) {
        throw RaylibException("Failed to create Window");
    }
}

since throw would already take care of error ?

@RobLoach
Copy link
Owner

That would seem appropriate. Good thinking 👍

@RobLoach RobLoach merged commit 7323fb3 into RobLoach:master Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants