Added fix in method toggle_rw where engine_path is hardcoded as Rvc64#4
Merged
RobThePCGuy merged 1 commit intoRobThePCGuy:masterfrom Feb 27, 2025
Merged
Conversation
…ed to Rvc64, I used name from selected_instance to ensure it finds the correct folder for the engine
RobThePCGuy
approved these changes
Feb 27, 2025
Owner
RobThePCGuy
left a comment
RobThePCGuy
left a comment
There was a problem hiding this comment.
This was most definitely an oversight on my part. Wonderful job in spotting it and for fixing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just used the name from selected_instances as parameter