Criterion is out of date

[jgabaut]

Criterion is out-of-date and would require a further bump of MSRV to 1.86.0, as per:

#99 (comment)

It being a dev-dependency only, should mean it's fine to treat just as the bump in this PR:

• bump rust-version to 1.85.0 + use Rust edition 2024 + apply new formatting #106

Thus allowing a 0.21 release with no deprecation warnings.

[xtqqczze]

@jgabaut I don't think upgrading from criterion 0.7 is particularly important. Is there a specific reason you would like criterion 0.8?

If cargo-outdated had an option to exclude dev-dependencies, then we could address the warning in CI, see kbknapp/cargo-outdated#408.

[jgabaut]

I don't think upgrading from criterion 0.7 is particularly important

I agree.

Is there a specific reason you would like criterion 0.8?

Nothing in particular, other than avoiding the unneded warning for users, as a prospective adopter of this dependency.

Weighing the cons of bumping,

• I am taking as a given that current benches would not need too much refactoring. If it's not the case and It would be troublesome, that's the first con.
• Tiny MSRV bump for dev-dependency only

If cargo-outdated had an option to exclude dev-dependencies, then we could address the warning in CI, see kbknapp/cargo-outdated#408.

Nice reference, I may look into it a bit.

[xtqqczze]

@jgabaut Would #108 resolve this issue for you?

[Robbepop]

@xtqqczze I still prefer bumping string-interner's MSRV from 1.85 to 1.86 as a solution instead of weakening the CI.

That is, unless there is a good reason to keep Rust 1.85 as MSRV.

[jgabaut]

@xtqqczze I still prefer bumping string-interner's MSRV from 1.85 to 1.86 as a solution instead of weakening the CI.

That is, unless there is a good reason to keep Rust 1.85 as MSRV.

I opened PR in case it's what it's needed.

Edit: updated PR to avoid bumping MSRV

• chore: bump criterion to 0.8.2 #110

[xtqqczze]

The version of Rust on Debian stable is currently Rust 1.85, so raising the library's MSRV solely for a benchmarking-related development dependency is just unnecessary.

[Robbepop]

The version of Rust on Debian stable is currently Rust 1.85 [..]

That's a good enough argument for me to postpone the MSRV bump for now.
Do you know the dates when Debian stable and thus its Rust version is updated?

[jgabaut]

That's a good enough argument for me to postpone the MSRV bump for now.

Yes, quite fair.

Do you know the dates when Debian stable and thus its Rust version is updated?

From a quick look It seems Debian 13.0 was released on 9 Aug 2025.

Latest minor version 13.4 was released on 14 Mar 2026.

I don't think a the next major release (forky) bumping rust over 1.85 will be out for roughly another year.

Plus, support for 13.x ends on 9 August 2028, not considering LTS.

[xtqqczze]

I’m not opposed to raising the MSRV if there’s a compelling reason to do so, such as adopting new language features or a newer version of hashbrown, but this alone doesn’t seem sufficient justification.

[jgabaut]

I’m not opposed to raising the MSRV if there’s a compelling reason to do so, such as adopting new language features or a newer version of hashbrown, but this alone doesn’t seem sufficient justification.

As said, I agree. The PR was updated to only bump criterion. Is that useful?