Skip to content

specify rust-version in Cargo.toml#101

Merged
Robbepop merged 1 commit intoRobbepop:masterfrom
xtqqczze:msrv
Apr 29, 2026
Merged

specify rust-version in Cargo.toml#101
Robbepop merged 1 commit intoRobbepop:masterfrom
xtqqczze:msrv

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 16, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.06%. Comparing base (67545c1) to head (c105a72).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   61.10%   61.06%   -0.04%     
==========================================
  Files          12       12              
  Lines         509      506       -3     
==========================================
- Hits          311      309       -2     
+ Misses        198      197       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented Apr 16, 2026

Run cargo outdated --root-deps-only --workspace --exit-code 1
string-interner
================
Name        Project  Compat  Latest   Kind         Platform
----        -------  ------  ------   ----         --------
criterion   0.7.0    ---     0.8.2    Development  ---
hashbrown   0.16.0   ---     0.17.0   Normal       ---
rustc-hash  2.1.1    ---     2.1.2    Development  ---
serde_json  1.0.145  ---     1.0.149  Development  ---
Error: Process completed with exit code 1.

hashbrown 0.17.0 has MSRV of 1.85.0

@xtqqczze
Copy link
Copy Markdown
Contributor Author

@Robbepop PTAL

@Robbepop
Copy link
Copy Markdown
Owner

CI is not happy, we may need to either reduce Rust edition to 2021 or bump the MSRV.

Run cargo install cargo-outdated
    Updating crates.io index
 Downloading crates ...
  Downloaded cargo-outdated v0.19.0
error: failed to parse manifest at `/home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/cargo-outdated-0.19.0/Cargo.toml`

Caused by:
  failed to parse the `edition` key

Caused by:
  this version of Cargo is older than the `2024` edition, and only supports `2015`, `2018`, and `2021` editions.
Error: Process completed with exit code 101.

@xtqqczze
Copy link
Copy Markdown
Contributor Author

CI is not happy, we may need to either reduce Rust edition to 2021 or bump the MSRV.

MSRV-aware solver isn't available until 1.84 anyway, so I reverted the CI changes

@Robbepop
Copy link
Copy Markdown
Owner

@xtqqczze thank you for the PR and improvements!

@Robbepop Robbepop merged commit dd3c7bb into Robbepop:master Apr 29, 2026
30 of 32 checks passed
@xtqqczze xtqqczze deleted the msrv branch April 29, 2026 14:42
@xtqqczze
Copy link
Copy Markdown
Contributor Author

@Robbepop would you now cut a new release with hashbrown 0.16?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants