Correction of issue 252#254
Merged
Robdel12 merged 5 commits intoRobdel12:masterfrom Nov 26, 2014
brianAround:master
Merged
Conversation
Modified select logic to prevent early exist from loop.
Gulped and complete
Added simple white space around operands/
As requested
Owner
|
Woops! Can this be made vs develop? I accidentally merged it without checking what branch it was going against. EDIT: We're actually switching to a one branch approach. Can you reopen the PR and we'll merge it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a minor change to the logic of the select() method that seems to correct the problem loading a value. It seems that it was exiting the for loop prematurely.