Skip to content

Fix disabled optgroups not being disabled in dropkick#348

Merged
Robdel12 merged 1 commit intomasterfrom
disabled-optgroups
Aug 1, 2017
Merged

Fix disabled optgroups not being disabled in dropkick#348
Robdel12 merged 1 commit intomasterfrom
disabled-optgroups

Conversation

@Robdel12
Copy link
Copy Markdown
Owner

Fixes #336

@Robdel12 Robdel12 requested a review from wwilsman July 31, 2017 02:30
Comment thread src/dropkick.js Outdated
case "OPTGROUP":
optgroup = _.create( "li", { "class": "dk-optgroup" });


Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who doesn't check their diffs before a commit? 😜

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guy

@Robdel12 Robdel12 force-pushed the disabled-optgroups branch from 81ca23f to 62126c0 Compare August 1, 2017 01:50
@Robdel12 Robdel12 merged commit 06068a0 into master Aug 1, 2017
@Robdel12 Robdel12 deleted the disabled-optgroups branch August 7, 2017 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants