Use NSString’s length instead of String.CharacterView.count, since we…#62
Merged
RobertGummesson merged 1 commit intoRobertGummesson:masterfrom Mar 31, 2017
Merged
Conversation
…’re going to use the range in an NSMakeRange call anyways
Owner
|
Thanks. That's interesting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…’re going to use the range in an NSMakeRange call anyways
String.CharacterView's count is taking 40% of the time parsing the logs:
Simply changing a line to use NSString's length property improves the performance by about 2x:
There's still a lot of time being spent with rangeOfCharacters, seems to be related to retain/releases, but this is a good starting improvement!