Skip to content

fix build bug due to private framework conflicts#2

Merged
Robertsmania merged 1 commit intoRobertsmania:improvements-1from
vincentneo:fix/network.framework
Feb 25, 2024
Merged

fix build bug due to private framework conflicts#2
Robertsmania merged 1 commit intoRobertsmania:improvements-1from
vincentneo:fix/network.framework

Conversation

@vincentneo
Copy link
Copy Markdown

It appears that Xcode is incorrectly attempting to load Network.framework from PrivateFrameworks rather than regular frameworks directory

Builds fine from my Mac, please try it out too.

Screenshot 2024-02-24 at 11 50 13 PM

It appears that Xcode is incorrectly attempting to load Network.framework from PrivateFrameworks rather than regular frameworks directory
@Robertsmania
Copy link
Copy Markdown
Owner

Robertsmania commented Feb 24, 2024

Yes, this does work to fix the build errors and import the Network framework.
Thank you!

Can you help me understand the change and where you made it in the IDE?

It's confusing to me that after getting your modified project.pbxproj file and building with that, reverting that file to the previous version does NOT go back to the broken state. It still builds! Even if I do a clean clone of the repository or try the vanilla improvements-1 project with the Network framework imported - that works too now. It's as if building sucessfully once has put files somewhere outside the project that Xcode now finds even with the previous project.pbxproj?!?

Copy link
Copy Markdown
Owner

@Robertsmania Robertsmania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does work, switching the Framework Search Path in Build Settings to look in PrivateFrameworks. But its confusing because at the file system level /System/Library/PrivateFrameworks/Network.framework is a symbolic link that points to /System/Library/Network.framework - so I would have kind of expected it to resolve to the same actual files either way...

@Robertsmania Robertsmania merged commit aa88fc0 into Robertsmania:improvements-1 Feb 25, 2024
@Robertsmania
Copy link
Copy Markdown
Owner

Screenshot 2024-02-24 at 3 38 13 PM I'm happy to move on now that it builds and runs, but it still bothers me a little that after one project compiles successfully any other project that failed to build before now works successfully without a similar change to the Build Settings / Framework Search Path. If anyone can help me understand the context for how that behavior manifests, it would be interesting to understand better whats going on.

@vincentneo
Copy link
Copy Markdown
Author

If anyone can help me understand the context for how that behavior manifests, it would be interesting to understand better whats going on.

Well to be fair, most users shouldn't use the private frameworks. v1.1 uses it for the media remote framework which is private. I just made a guess that it could be conflicting and it turned out to be true :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants