Update index.js #19
Merged
Update index.js #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 21, 2018
| try { | ||
| store = typeof window !== 'undefined' && v in window ? window[v] : undefined; | ||
| } catch (e) { console.log(v + ' error: ' + e) } | ||
| }) |
| if (store) return; | ||
| try { | ||
| store = typeof window !== 'undefined' && v in window ? window[v] : undefined; | ||
| } catch (e) { console.log(v + ' error: ' + e) } |
| ? window.localStorage | ||
| : Memory; | ||
| let store; | ||
| ['localStorage', 'sessionStorage'].forEach( v => { |
There was a problem hiding this comment.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
| const store = typeof window !== 'undefined' && 'localStorage' in window | ||
| ? window.localStorage | ||
| : Memory; | ||
| let store; |
There was a problem hiding this comment.
'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
1 similar comment
Owner
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases IE10-11 protected mode gives error "Access denied" when localStorage is accessed. Fallback is sessionStorage and then Memory.