Skip to content

Update index.js #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2018
Merged

Update index.js #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
import Memory from './memory';
import Storage from './storage';

const store = typeof window !== 'undefined' && 'localStorage' in window
? window.localStorage
: Memory;
let store;
Copy link

@houndci-bot houndci-bot Feb 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

['localStorage', 'sessionStorage'].forEach( v => {
Copy link

@houndci-bot houndci-bot Feb 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

if (store) return;
try {
store = typeof window !== 'undefined' && v in window ? window[v] : undefined;
} catch (e) { console.log(v + ' error: ' + e) }
Copy link

@houndci-bot houndci-bot Feb 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

})
Copy link

@houndci-bot houndci-bot Feb 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

if (!store) store = Memory;
const ls = new Storage(store);

const VueLocalStorage = {
Expand Down