You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a side-note, Windows doesn't require the cwd to be on PATH, as it implicitly searches there first. It may be preferable to omit path modification entirely on windows. Likewise .exe is unnecessary on windows, though may be desired anyway?
Edit: I just had a check, and lute relies on libuv for process spawning. This bypasses a lot of the normal windows mechanisms. From what I can tell, libuv's search order is mostly analogous to how windows normally searches for paths, and notably does first search the cwd, and will also implicitly add .com or .exe if omitted from the name. I think based on that it's probably preferable to omit adding .exe or modifying PATH entirely, but it's your call which is preferred. I checked and / is coerced into \\ so no issues elsewhere regarding that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows uses
;as the separator in PATH as opposed to:on unix-like systems.