Update Mac Release Name To Reflect Proper Architecture Arm64#27
Merged
afujiwara-roblox merged 2 commits intomasterfrom Apr 13, 2026
Merged
Update Mac Release Name To Reflect Proper Architecture Arm64#27afujiwara-roblox merged 2 commits intomasterfrom
afujiwara-roblox merged 2 commits intomasterfrom
Conversation
| - name: Zip release artifacts | ||
| run: | | ||
| zip -rj rocale-cli-macos-x86_64.zip ./artifacts/rocale-cli-macos-x86_64/* | ||
| zip -rj rocale-cli-macos-arm64.zip ./artifacts/rocale-cli-macos-x86_64/* |
There was a problem hiding this comment.
should we rename the upload-artifact step as well?
Contributor
Author
There was a problem hiding this comment.
Yeah let's be consistent
raymondnumbergenerator
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25
The mac rocale-cli binaries is tagged as
x86_64when it is actuallyarm64. We should update the release name to reflect that.