Skip to content

Refactor: Replace 'classification' with 'trait' in GraphQL queries #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfrench9 merged 1 commit into from
Apr 25, 2026
+17 −17
Merged

Refactor: Replace 'classification' with 'trait' in GraphQL queries #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions robosystems_client/graphql/queries/ledger/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def parse_summary(data: dict[str, Any]) -> dict[str, Any] | None:
code
name
description
classification
trait
subClassification
balanceType
parentId
Expand Down Expand Up @@ -165,13 +165,13 @@ def parse_accounts(data: dict[str, Any]) -> dict[str, Any] | None:
accountTree {
totalAccounts
roots {
id code name classification accountType balanceType depth isActive
id code name trait accountType balanceType depth isActive
children {
id code name classification accountType balanceType depth isActive
id code name trait accountType balanceType depth isActive
children {
id code name classification accountType balanceType depth isActive
id code name trait accountType balanceType depth isActive
children {
id code name classification accountType balanceType depth isActive
id code name trait accountType balanceType depth isActive
}
}
}
Expand Down Expand Up @@ -205,7 +205,7 @@ def parse_account_tree(data: dict[str, Any]) -> dict[str, Any] | None:
reportingElementId
reportingName
reportingQname
classification
trait
balanceType
total
accounts {
Expand Down Expand Up @@ -238,7 +238,7 @@ def parse_account_rollups(data: dict[str, Any]) -> dict[str, Any] | None:
accountId
accountCode
accountName
classification
trait
accountType
totalDebits
totalCredits
Expand Down Expand Up @@ -270,7 +270,7 @@ def parse_trial_balance(data: dict[str, Any]) -> dict[str, Any] | None:
reportingElementId
qname
reportingName
classification
trait
balanceType
totalDebits
totalCredits
Expand Down Expand Up @@ -395,7 +395,7 @@ def parse_taxonomies(data: dict[str, Any]) -> list[dict[str, Any]]:
) {
elements {
id code name description qname namespace
classification subClassification balanceType periodType
trait subClassification balanceType periodType
isAbstract elementType source taxonomyId parentId depth
isActive externalId externalSource
}
Expand All @@ -413,7 +413,7 @@ def parse_elements(data: dict[str, Any]) -> dict[str, Any] | None:
LIST_UNMAPPED_ELEMENTS_QUERY = """
query ListLedgerUnmappedElements($mappingId: String) {
unmappedElements(mappingId: $mappingId) {
id code name classification balanceType externalSource
id code name trait balanceType externalSource
suggestedTargets { elementId qname name confidence }
}
}
Expand Down Expand Up @@ -697,7 +697,7 @@ def parse_report(data: dict[str, Any]) -> dict[str, Any] | None:
reportId structureId structureName structureType unmappedCount
periods { start end label }
rows {
elementId elementQname elementName classification
elementId elementQname elementName trait
values isSubtotal depth
}
validation { passed checks failures warnings }
Expand Down
12 changes: 6 additions & 6 deletions robosystems_client/graphql/queries/library/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def parse_library_taxonomy(data: dict[str, Any]) -> dict[str, Any] | None:
qname
namespace
name
classification
trait
statementContext
derivationRole
balanceType
Expand Down Expand Up @@ -146,7 +146,7 @@ def parse_library_elements(data: dict[str, Any]) -> list[dict[str, Any]]:
qname
namespace
name
classification
trait
statementContext
derivationRole
balanceType
Expand Down Expand Up @@ -184,7 +184,7 @@ def parse_library_search_results(data: dict[str, Any]) -> list[dict[str, Any]]:
qname
namespace
name
classification
trait
statementContext
derivationRole
balanceType
Expand Down Expand Up @@ -272,7 +272,7 @@ def parse_library_taxonomy_arcs(data: dict[str, Any]) -> dict[str, Any]:
id
qname
name
classification
trait
statementContext
derivationRole
source
Expand All @@ -294,7 +294,7 @@ def parse_library_element_arcs(data: dict[str, Any]) -> list[dict[str, Any]]:
id
qname
name
classification
trait
statementContext
derivationRole
source
Expand All @@ -303,7 +303,7 @@ def parse_library_element_arcs(data: dict[str, Any]) -> list[dict[str, Any]]:
id
qname
name
classification
trait
statementContext
derivationRole
source
Expand Down
Loading