Enhance SyncConnectionRequest with full rebuild and since date support#108
Merged
Enhance SyncConnectionRequest with full rebuild and since date support#108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the event-driven ingestion pipeline by extending the
SyncConnectionRequestmodel with new attributes (full_rebuildandsince_date) and updating theop_update_event_blockoperation to leverage these capabilities. These changes enable more flexible control over synchronization behavior, allowing callers to request full data rebuilds or incremental syncs from a specific date.Key Accomplishments
SyncConnectionRequestmodel: Addedfull_rebuild(boolean) andsince_date(date/datetime) attributes to the sync connection request, providing granular control over sync operations.op_update_event_block: Enhanced the event block update operation to accommodate the new request attributes, ensuring the API layer properly handles full rebuild and date-based sync scenarios.Breaking Changes
SyncConnectionRequestmodel signature has been extended. Existing consumers that instantiate the model via positional arguments or perform strict schema validation may need to be updated to account for the new optional fields. However, since these are additive attributes, backward compatibility should be maintained for most standard usage patterns.Testing Notes
SyncConnectionRequestcan be instantiated with and without the newfull_rebuildandsince_dateattributes (ensure backward compatibility with existing call sites).full_rebuild=Truetriggers the expected full data rebuild behavior end-to-end through the event block update operation.since_datecorrectly scopes the sync to only process data from the specified date onward.Infrastructure Considerations
🤖 Generated with Claude Code
Branch Info:
feature/event-driven-ingestmainCo-Authored-By: Claude noreply@anthropic.com