feat: add S3 endpoint configuration for LocalStack compatibility #43
Conversation
- Introduced `s3_endpoint_url` to `RoboSystemsExtensionConfig` for optional S3 endpoint overrides, facilitating integration with services like LocalStack. - Updated `FileClient` to utilize the new `s3_endpoint_url` for overriding upload URLs, enhancing flexibility in file upload operations. These changes improve the configurability of S3 interactions within the client.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| upload_url = urlunparse( | ||
| ( | ||
| override_parsed.scheme or parsed_url.scheme, | ||
| override_parsed.netloc, | ||
| parsed_url.path, |
There was a problem hiding this comment.
When s3_endpoint_url is set, the upload URL is rebuilt with the override netloc but keeps only parsed_url.path. For common virtual-host–style presigned URLs (bucket encoded in the hostname), this drops the bucket name when swapping to a LocalStack/alternative endpoint (e.g., https://bucket.s3.amazonaws.com/key becomes http://localhost:4566/key), so the PUT targets the root rather than the bucket and the upload fails with 403/404. This affects any client using virtual-host presigned URLs with a custom endpoint—precisely the LocalStack scenario this change is meant to support.
Useful? React with 👍 / 👎.
Summary
This PR enhances the RoboSystemsExtension to support custom S3 endpoint configuration, enabling better compatibility with LocalStack and other S3-compatible services for local development and testing environments.
Key Changes
Key Accomplishments
Breaking Changes
None. This change is fully backward compatible with existing configurations.
Testing Notes
Infrastructure Considerations
🤖 Generated with Claude Code
Branch Info:
feature/improve-localstack-s3-compatibilitymainCo-Authored-By: Claude noreply@anthropic.com