Add schedule & closing entry APIs, remove legacy extensions#78
Merged
Add schedule & closing entry APIs, remove legacy extensions#78
Conversation
…thods - Replaced `ElementAssociationResponse` with `AssociationResponse` in the mapping association API, ensuring consistency across response types. - Updated method signatures and return types in `create_mapping_association.py` to reflect the new response model. - Removed the obsolete `ElementAssociationResponse` model from the codebase. - Enhanced the `__init__.py` file to include the new `AssociationResponse` model for public access. These changes streamline the API response structure and improve clarity in the mapping association functionality.
- Deleted the `subgraph_workspace_client.py` and `view_builder_client.py` files, along with their associated classes and methods, to streamline the codebase. - Updated `__init__.py` to remove references to the deleted extensions, ensuring a clean public API. - These changes simplify the client structure and focus on core functionalities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces comprehensive schedule management and period closing capabilities to the ledger API while removing deprecated client extensions (Subgraph Workspace and View Builder). It also refactors the mapping association response model for consistency.
Key Accomplishments
New Ledger API Endpoints
create_schedule.py) — Create new schedules with metadata and entry templateslist_schedules.py) — Retrieve available schedulesget_schedule_facts.py) — Fetch fact data associated with schedulescreate_closing_entry.py) — Support for period-end closing entriesget_period_close_status.py) — Query the status of period close processesNew Models (16 added)
CreateScheduleRequest,ScheduleCreatedResponse,ScheduleSummaryResponse,ScheduleListResponse,ScheduleFactResponse,ScheduleFactsResponse,ScheduleMetadataRequest,ScheduleSummaryResponseEntryTemplateType0,ScheduleSummaryResponseScheduleMetadataType0CreateClosingEntryRequest,ClosingEntryResponsePeriodCloseStatusResponse,PeriodCloseItemResponse,PeriodSpecEntryTemplateRequestRefactoring
ElementAssociationResponse→AssociationResponsefor broader applicability (R097 — 97% similarity)MappingDetailResponseandcreate_mapping_associationAPI to reference the renamed modelCreateReportRequest,RegenerateReportRequest,ReportResponse,FactRowResponse, andStatementResponsewith additional fields and updated type handlingCreateStructureRequestStructureTypeandCreateTaxonomyRequestTaxonomyTypeRemoved Legacy Extensions
SubgraphWorkspaceClient(746 lines) — deprecated subgraph workspace functionalityViewBuilderClient(601 lines) — deprecated view builder functionality__init__.pyto remove all exports (module retained but emptied)Breaking Changes
ElementAssociationResponserenamed toAssociationResponse— Any code importing or referencingElementAssociationResponsemust be updated.SubgraphWorkspaceClientremoved — Consumers relying on this extension must migrate to alternative approaches.ViewBuilderClientremoved — Consumers relying on this extension must migrate to alternative approaches.from robosystems_client.extensions import *will no longer provide any classes.StatementResponse,FactRowResponse,CreateReportRequest, andRegenerateReportRequesthave structural changes that may affect deserialization in downstream consumers.Testing Notes
AssociationResponsemodel correctly deserializes in mapping association flowsElementAssociationResponse,StatementResponse, orFactRowResponsegiven field changesInfrastructure Considerations
robosystems_clientwill need to update their dependencies and adapt to breaking changes🤖 Generated with Claude Code
Branch Info:
feature/schedulesmainCo-Authored-By: Claude noreply@anthropic.com