refactor!: device ids are now passed through the config#276
Merged
Conversation
- the config for each device must now hold its id e.g. its ip address instead of explicitly passing it - robotiqgripper in the UR5e extension now has its own config
juelg
force-pushed
the
juelg/refactor-configs
branch
from
4cf9b03 to
be422ff
Compare
- corrected config extension by using normal python classes and not dataclasses - added unpack type hinting type kwargs for base classes - added auto generated typed dict file for base config class types that come from cpp
juelg
force-pushed
the
juelg/refactor-configs
branch
from
ee40d2c to
80365a8
Compare
- robot wrapper: home_on_reset -> into robot config - robot wrapper: home position for home_on_reset configurable in robot config - gripper wrapper: binary -> into gripper config
juelg
force-pushed
the
juelg/refactor-configs
branch
from
80365a8 to
3512142
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.