Skip to content

Conversation

@suman1209
Copy link
Contributor

@suman1209 suman1209 commented Jul 11, 2024

Factory functions that produce correctly wrapped and configured typed gymnasium (hardware and simulation) environments for the FR3. Closes #83

juelg and others added 2 commits July 11, 2024 12:13
added sim creation functions for sim, tquart
@suman1209 suman1209 self-assigned this Jul 11, 2024
@suman1209 suman1209 requested a review from juelg July 11, 2024 13:43
@suman1209 suman1209 changed the base branch from master to juelg/real-robot-and-digital-twin July 11, 2024 13:44
@juelg juelg changed the title Feat/typed factory envs Typed Factory for Gym Envs Jul 11, 2024
added sim creation functions for trpy and joints
@juelg juelg changed the base branch from juelg/real-robot-and-digital-twin to develop July 18, 2024 06:47
@juelg
Copy link
Contributor

juelg commented Jul 18, 2024

Please have a look at the two commits that I have added. The first one includes some type hint fixes, which need to be applied for the remaining functions and the second includes a small example to test out the factory functions.

After all functions have been applied, please test them with the given example. Please also write some integration tests that which test the simulation gym environment. For more details see issue #83.

When you are done, check formatting and linting with the corresponding make commands.

juelg and others added 8 commits July 18, 2024 11:41
Fixed type hints, env naming and upsis
added hw env creation functions for trpy,joints and tqwart control modes
added hw env creation functions for trpy,joints and tqwart control modes
pylint fixes
added initial integration tests
update to the integration tests
formated code for isort issue and black format
@suman1209
Copy link
Contributor Author

Please have a look at the two commits that I have added. The first one includes some type hint fixes, which need to be applied for the remaining functions and the second includes a small example to test out the factory functions.

After all functions have been applied, please test them with the given example. Please also write some integration tests that which test the simulation gym environment. For more details see issue #83.

When you are done, check formatting and linting with the corresponding make commands.

I have pushed the integration tests with some issues marked with a TODO, can you review this branch and let me know.
Thanks

@juelg juelg force-pushed the feat/typed-factory-envs branch from cff6029 to 0feb80c Compare August 15, 2024 13:51
@juelg juelg force-pushed the feat/typed-factory-envs branch from 0feb80c to c74f695 Compare August 15, 2024 14:17
@juelg juelg marked this pull request as ready for review August 15, 2024 14:23
@suman1209 suman1209 marked this pull request as draft August 21, 2024 15:37
@juelg juelg force-pushed the feat/typed-factory-envs branch from 18ad59e to c74f695 Compare August 22, 2024 09:53
@juelg juelg force-pushed the feat/typed-factory-envs branch from a36b3f1 to 4115a32 Compare August 23, 2024 14:05
@juelg juelg marked this pull request as ready for review August 23, 2024 14:06
@juelg juelg merged commit ccf7338 into develop Aug 25, 2024
@juelg juelg deleted the feat/typed-factory-envs branch August 25, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typed Factory Functions for FR3 Gymnasium Environments

3 participants