-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added parallelization to PreprocessShortestPath. #21770
base: master
Are you sure you want to change the base?
Added parallelization to PreprocessShortestPath. #21770
Conversation
\CC @cohnt FYI |
A few big picture points: (1) Drake avoids unbounded parallelism. Every multicore par-for loop must always have a governor for max number of cores. Typically this a (2) For binning work across cores, we typically use our |
(3) For efficiency, there should be one mathematical program per core, not one program per edge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related issue is #19119. Perhaps resolving there would be more appropriate than having ad-hoc parallelization of solving MathematicalPrograms scattered throughout Drake.
Reviewable status: LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits), missing label for release notes (waiting on @adityapande-1995)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits), missing label for release notes (waiting on @adityapande-1995)
This PR tries to resolve #21705 by parallelizing the MathematicalProgram solving. I'm not sure if this solves the problem, but I'm open for suggestions :)
This change is