Skip to content

ActionServer cancelRequestHandler() missing goalHandler param #866

@wayneparrott

Description

@wayneparrott

While implementing an ActionServer I noticed the CancelCallback fn declaration is missing the GoalHandle parameter.

type CancelCallback = () => Promise<CancelResponse> | CancelResponse;

Based on the ROS2 C++ action api the CancelCallback declaration should be:

type CancelCallback<T extends TypeClass<ActionTypeClassName>> = (
    goalHandle: ServerGoalHandle<T>
  ) => Promise<CancelResponse> | CancelResponse;

Additionally, test-action-server.js includes 2 test cases that need small modification to reflect this change.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions