Skip to content

Pump to Node 26.x#1497

Merged
minggangw merged 1 commit intoRobotWebTools:developfrom
minggangw:fix-1458-7
May 6, 2026
Merged

Pump to Node 26.x#1497
minggangw merged 1 commit intoRobotWebTools:developfrom
minggangw:fix-1458-7

Conversation

@minggangw
Copy link
Copy Markdown
Member

@minggangw minggangw commented May 6, 2026

Updates CI workflow matrices to adjust the Node.js versions used for Linux builds/tests, aligning (at least partially) with a move toward newer Node majors.

Changes:

  • Linux x64 CI matrix: replaces Node 25.x testing with Node 26.x (keeps Node 24.x).
  • Linux arm64 CI matrix: switches from a pinned Node 20.20.2 to a floating Node 20.x range.

Fix: #1458

Copilot AI review requested due to automatic review settings May 6, 2026 02:06
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates CI workflow matrices to adjust the Node.js versions used for Linux builds/tests, aligning (at least partially) with a move toward newer Node majors.

Changes:

  • Linux x64 CI matrix: replaces Node 25.x testing with Node 26.x (keeps Node 24.x).
  • Linux arm64 CI matrix: switches from a pinned Node 20.20.2 to a floating Node 20.x range.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/linux-x64-build-and-test.yml Updates the x64 build/test matrix to include Node 26.x (and drop 25.x).
.github/workflows/linux-arm64-build-and-test.yml Changes the arm64 build/test matrix from a pinned Node 20.20.2 to Node 20.x.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

fail-fast: false
matrix:
node-version: [24.X, 25.X]
node-version: [24.X, 26.X]
fail-fast: false
matrix:
node-version: [20.20.2]
node-version: [20.X]
@minggangw minggangw merged commit 03518c3 into RobotWebTools:develop May 6, 2026
19 checks passed
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 85.864%. remained the same — minggangw:fix-1458-7 into RobotWebTools:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Roadmap: Prepare rclnodejs for ROS 2 Lyrical Luth

3 participants