Skip to content

[Prebuild] Add Lyrical Luth lane to Linux prebuild workflows#1498

Merged
minggangw merged 1 commit intoRobotWebTools:developfrom
minggangw:fix-1458-9
May 6, 2026
Merged

[Prebuild] Add Lyrical Luth lane to Linux prebuild workflows#1498
minggangw merged 1 commit intoRobotWebTools:developfrom
minggangw:fix-1458-9

Conversation

@minggangw
Copy link
Copy Markdown
Member

@minggangw minggangw commented May 6, 2026

Generate prebuilt binaries for ROS 2 Lyrical Luth (Ubuntu 26.04 / resolute) on both x64 and ARM64. The existing prebuild scripts are distro-agnostic and pick up ROS_DISTRO + Ubuntu codename automatically, so no changes are required in scripts/tag_prebuilds.js, scripts/install.js, lib/prebuilds.js, or lib/native_loader.js.

Changes:

  • .github/workflows/prebuild-linux-x64.yml: Add lyrical to the ros_distribution matrix with docker_image: ubuntu:26.04, ubuntu_codename: resolute, and the Lyrical beta tarball URL (ros2-lyrical-2026-04-30-resolute-x86_64.tar.bz2). Skip ros-tooling/setup-ros for Lyrical and instead enable the ROS 2 apt source, install build/rosdep tooling, extract the tarball into /opt/ros/lyrical, and resolve runtime deps via rosdep install (mirroring the Lyrical lane already used in the test workflow).
  • .github/workflows/prebuild-linux-arm64.yml: same as above, using the aarch64 Lyrical tarball.

Fix: #1458

Copilot AI review requested due to automatic review settings May 6, 2026 03:16
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds ROS 2 Lyrical Luth as an additional lane in the Linux prebuild GitHub Actions workflows so the project can publish prebuilt .node artifacts for Lyrical on both x64 and arm64. This aligns the prebuild pipelines with the repo’s existing Lyrical support pattern (installing from a beta binary tarball rather than setup-ros).

Changes:

  • Extend the Linux x64 and arm64 prebuild matrices to include lyrical on Ubuntu 26.04 (resolute).
  • For lyrical, bypass ros-tooling/setup-ros and instead:
    • enable the ROS 2 apt repository (for rosdep/system deps),
    • install ROS 2 from a pinned beta tarball URL,
    • run rosdep install against the extracted /opt/ros/lyrical tree.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/prebuild-linux-x64.yml Adds a lyrical matrix entry and installs Lyrical via beta tarball + rosdep instead of setup-ros.
.github/workflows/prebuild-linux-arm64.yml Mirrors the x64 workflow changes for arm64, using the aarch64 Lyrical beta tarball.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coveralls
Copy link
Copy Markdown

coveralls commented May 6, 2026

Coverage Status

No base build to compare — minggangw:fix-1458-9 into RobotWebTools:develop

@minggangw minggangw changed the title [Prebuild]add Lyrical Luth lane to Linux prebuild workflows [Prebuild] Add Lyrical Luth lane to Linux prebuild workflows May 6, 2026
@minggangw minggangw merged commit 9031f44 into RobotWebTools:develop May 6, 2026
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Roadmap: Prepare rclnodejs for ROS 2 Lyrical Luth

3 participants