Install test-msgs and mrpt-msgs uniformly across all ROS 2 distros#1518
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the CI workflows to install ros-<distro>-test-msgs and ros-<distro>-mrpt-msgs via apt across all ROS 2 distro lanes, restoring pre-#1496 behavior now that mrpt-msgs is available on packages.ros.org for Rolling and Lyrical.
Changes:
- Removes the conditional gates that previously skipped installing
test-msgs/mrpt-msgson the Rolling and/or Lyrical lanes. - Simplifies the Lyrical apt install steps to install only
ros-lyrical-desktop, relying on the shared message-package install step afterward.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/linux-x64-build-and-test.yml | Makes the message-package install step run for all distros; trims Lyrical apt install package list. |
| .github/workflows/linux-arm64-build-and-test.yml | Makes the message-package install step run for all distros; trims Lyrical apt install package list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
108
to
110
| - name: Install test-msgs and mrpt_msgs on Linux | ||
| if: ${{ matrix.ros_distribution != 'rolling' && matrix.ros_distribution != 'lyrical' }} | ||
| run: | | ||
| sudo apt install -y ros-${{ matrix.ros_distribution }}-test-msgs ros-${{ matrix.ros_distribution }}-mrpt-msgs |
|
coverage: 85.474%. remained the same — minggangw:fix-1458-16 into RobotWebTools:develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the lyrical-specific
ros-lyrical-test-msgs/ros-lyrical-mrpt-msgslines from the "Install ROS2 from apt (lyrical)" step and instead let the shared "Install test-msgs and mrpt_msgs on Linux" step handle them, the same way it already does for humble / jazzy / kilted. Keep the!= 'rolling'gate on the shared step becausepackages.ros.orgdoes not publishros-rolling-*debs for theresolute(Ubuntu 26.04) codename — Rolling remains tarball-only there..github/workflows/linux-x64-build-and-test.yml— extend the shared step to lyrical; trim the lyrical apt step toros-lyrical-desktoponly..github/workflows/linux-arm64-build-and-test.yml— same trim; the shared step has noif:here because arm64 has no rolling lane.Refs: a3bb702 ("Add ROS 2 Lyrical Luth (#1496)")
Fix: #1458